feat(db): add RocksDB benchmark configuration - #48
Draft
bladehan1 wants to merge 15 commits into
Draft
Conversation
Allow FullNode and BlockReplay to apply restricted RocksDB setting overlays. Add native option validation and profile labels for repeatable E1/E2 tests.
Keep the no-profile path aligned with the pre-profile native setter behavior. Opt benchmark profiles into custom options and cover legacy and custom selection with tests.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bladehan1
force-pushed
the
feature/rocksdb_config_benchmark
branch
3 times, most recently
from
August 12, 2026 10:02
846001c to
b876295
Compare
bladehan1
force-pushed
the
feature/rocksdb_config_benchmark
branch
from
August 12, 2026 10:12
b876295 to
4bca2f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
--rocksdb-configoverlay for FullNode and BlockReplayWhy are these changes required?
Fixed-block replay benchmarks need an easy way to change one RocksDB variable without allowing an
experiment file to alter unrelated node settings. The first no-profile A1 comparison also showed that
the new configuration implementation changed several native RocksDB Options at once, so its performance
difference could not be attributed to the profile framework. The legacy path keeps the no-profile case
compatible and provides a valid implementation-isolation gate before parameter tuning begins.
This PR has been tested by:
:common:testforRocksDbSettingsTestandStorageConfigTest:framework:testforConfigurationTestandBlockReplayTest:framework:checkstyleMain:framework:checkstyleTest:framework:buildFullNodeJarFollow up
--rocksdb-configExtra details
This diff also removes five
.dev_ops/bench_dbexperiment documents that were previously force-added tothe target branch. These are local benchmark artifacts and remain excluded from normal Git tracking.
Summary by cubic
Adds a restricted
--rocksdb-configoverlay forRocksDBbenchmarks and lightweight get-path metrics so E1/E2 tests are repeatable without touching other node settings. Default behavior keeps the prior native options; opting into a profile enables validated table/cache tuning, targeted Bloom, a shared cache, randomized PerfContext sampling, and optional per‑level block‑cache tracing.--rocksdb-configoverlays onlystorage.dbSettings; recordsbenchmarkProfileandbenchmarkMode(E1/E2). Legacy options remain default (useLegacyOptions=true). Profiles can set table/cache/write‑buffer/compaction/CompressionType, enable targeted Bloom (allow‑list orbloomFilterBitsPerKey> 0), and use a process‑wide sharedLRUCachevialegacySharedBlockCache/blockCacheSize(size‑guarded).BlockReplayaccepts and logs the profile.tron:db_gethit/miss counters and sampled PerfContext export totron:db_get_perfwith randomized per‑get sampling and per‑DB allow‑lists. Supports optional per‑level block‑cache trace with one‑in‑N sampling, DB allow‑list, and window isolation; a version‑matched JNI bridge forrocksdbjni9.7.xwrites bounded per‑DB CSV.RocksDbRebuildto rewrite/force‑compact snapshots so new SSTs use the active table options; compaction runs in parallel and the source database opens read‑only. AddsRocksDbBlockCacheTraceAnalyzerto aggregate per‑DB CSV traces. Extends tests across config merge, legacy vs. custom paths, shared cache, targeted Bloom, get outcomes and PerfContext sampling, block‑cache trace isolation, and the rebuild CLI; updatesreference.conf. Removes local.dev_ops/bench_dbdocs and ignores/.dev_ops/.Rollout
--rocksdb-configto opt in to custom options during benchmarks.rocksdbjni9.7.x, and configure a DB allow‑list.RocksDbRebuild(parallel compaction; read‑only source) to force‑compact to current options.Written for commit c6681d8. Summary will update on new commits.