You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
write_structure_to_ctab() (used by MOLFile.set_structure(), SDRecord.set_structure() and mol.set_structure()) built each atom/bond line by indexing NumPy arrays element-wise (atoms.coord[i, 0], atoms.element[i], charge[i], bond array rows), and re-formatted constant padding fields for every line.
Fix: iterate over tolist() versions of coordinates, elements, charges and the bond array, and format the constant unused fields once. Output is identical to main (V2000 and V3000).
No successful run was found on main (b0d32ca) during the generation of this report, so 81df912 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write_structure_to_ctab()(used byMOLFile.set_structure(),SDRecord.set_structure()andmol.set_structure()) built each atom/bond line by indexing NumPy arrays element-wise (atoms.coord[i, 0],atoms.element[i],charge[i], bond array rows), and re-formatted constant padding fields for every line.Fix: iterate over
tolist()versions of coordinates, elements, charges and the bond array, and format the constant unused fields once. Output is identical tomain(V2000 and V3000).13136.sdf(39 atoms)write_structure_to_ctab(..., "V2000")HWB.sdfwrite_structure_to_ctab(..., "V2000")ATP(CCD)SDRecord.set_structure(..., version="V2000")ATP(CCD)SDRecord.set_structure(..., version="V3000")13136.sdfSDRecord.set_structure(..., version="V2000")Tests run:
tests/structure/io/test_mol.py.Authored by Claude