Repository navigation
feat: Heartbeat the Makeswift preview session - #1415
Conversation
This was referenced Oct 8, 2026
parthshahp
added this pull request to stack #1417
October 8, 2026 15:17
parthshahp
force-pushed
the
parthshah/ltrac-1796-stencil-cli-session-heartbeat-and-re-registration-on-expiry
branch
from
October 8, 2026 15:18
b319e43 to
bf8fded
Compare
parthshahp
marked this pull request as ready for review
October 8, 2026 17:56
rtalvarez
reviewed
Oct 8, 2026
rtalvarez
left a comment
rtalvarez
left a comment
Member
There was a problem hiding this comment.
I wonder if we can just use a heartbeat library to alleviate some of the stuff in this PR
parthshahp
force-pushed
the
parthshah/ltrac-1796-stencil-cli-session-heartbeat-and-re-registration-on-expiry
branch
from
October 9, 2026 15:06
bf8fded to
32da3fb
Compare
Contributor
Author
|
Couldn't find one that fit our use case well without also requiring more boiler plate than we already have. I refactored the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Send a heartbeat to keep the Makeswift preview session alive, and register again when the session expires.
Tickets / Documentation
cc @bigcommerce/storefront-team