Repository navigation
fix(packaging): name the launcher icon dev.beyondhumane.Arca - #56
Merged
Merged
Conversation
Icon themes such as Colloid ship an unrelated 'arca' icon, and the active theme wins over hicolor, so the launcher showed the wrong one. The desktop file, the .deb, the AppImage and the Nix package now all use a reverse-DNS icon name nobody else can shadow. The desktop file name and the app_id stay 'arca'. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Launchers resolved
Icon=arcato the active icon theme first, and themes such as Colloid ship an unrelatedarca.svg, so Arca showed another app's icon instead of its own (hicolor is only the fallback). The icon is now installed and requested under a reverse-DNS name nobody else can shadow:Applied in all four places that name the file:
packaging/linux/arca.desktop,packaging/linux/build.sh(.deb staging and AppImage),packaging/linux/nfpm.yaml, andmakeDesktopItem { icon }+postInstallinpackaging/nix/package.nix.Deliberately unchanged: the desktop file stays
arca.desktopand the window keepswith_app_id("arca"), so compositors andmimeapps.listentries keep associating the window with its desktop entry; only the icon name moves.Link to Devin session: https://app.devin.ai/sessions/19c0b631a68145159a99f790aaa6eedd
Open in Devin Desktop: https://app.devin.ai/desktop/session/19c0b631a68145159a99f790aaa6eedd?variant=devin
Requested by: @Villoh