#535 - Align plan version history dates - #1377
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses the one-day mismatch in plan version history timestamps (vs. the downloaded PDF) by formatting submission/approval times in an explicit BC/Pacific timezone rather than the user’s browser timezone.
Changes:
- Added a new
formatPlanVersionDateutility that converts timestamps from UTC toAmerica/Vancouverbefore formatting. - Updated the plan versions dropdown list to use the new formatter instead of
moment(...)with implicit browser timezone.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/utils/format/date.ts | Introduces Day.js timezone-based formatter (formatPlanVersionDate) for plan version timestamps. |
| src/components/rangeUsePlanPage/versionsList/VersionsDropdownList.tsx | Switches version history date rendering to the new timezone-aware formatter. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Suppressed comments (1)
src/components/rangeUsePlanPage/versionsList/VersionsDropdownList.tsx:57
- PR description says it “replace[s] the implicit browser timezone for this view”, but this view still renders attachment timestamps via
moment(attachment.createdAt)(insrc/components/rangeUsePlanPage/versionsList/AttachmentsList.tsx:64), which remains browser-timezone dependent. If the intent is full consistency within the version history dropdown, consider updating AttachmentsList to use the sameformatPlanVersionDate/timezone approach as the version rows.
<TableCell>{formatPlanVersionDate(option.version.createdAt)}</TableCell>
<TableCell>{option.version.approvedBy}</TableCell>
<TableCell>{formatPlanVersionDate(option.version.approvedAt)}</TableCell>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
The matching API changes are in bcgov/range-api#537.
Closes #1376