Escape subtrans URL path segments and strip only a leading BOM - #492
Open
KillerX wants to merge 2 commits into
Open
Escape subtrans URL path segments and strip only a leading BOM#492KillerX wants to merge 2 commits into
KillerX wants to merge 2 commits into
Conversation
KillerX
force-pushed
the
fix/10-subtrans-url-bom
branch
from
August 21, 2026 10:59
402fc74 to
da4d2b4
Compare
url.PathEscape on every value interpolated into a request path, and bytes.TrimPrefix instead of bytes.Trim so a BOM inside or at the end of a subtitle body is left alone. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
KillerX
force-pushed
the
fix/10-subtrans-url-bom
branch
from
August 21, 2026 11:09
da4d2b4 to
09783c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File names/ids were concatenated into URL paths unescaped; stripBOM used bytes.Trim (cutset, both ends) instead of TrimPrefix.
Part of the stacked bugfix series fix/00 → fix/20; based on
fix/09-tc-samples-fps.🤖 Generated with Claude Code