Propagate I/O errors from IsDirEmpty instead of reporting empty - #489
Open
KillerX wants to merge 2 commits into
Open
Propagate I/O errors from IsDirEmpty instead of reporting empty#489KillerX wants to merge 2 commits into
KillerX wants to merge 2 commits into
Conversation
KillerX
force-pushed
the
fix/07-isdirempty-eof
branch
from
August 21, 2026 10:59
6b37a53 to
3f9e2ab
Compare
Only io.EOF from Readdirnames means the directory is empty; any other error (permission denied, not a directory, EIO) is now returned to the caller instead of classifying the directory as empty. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
KillerX
force-pushed
the
fix/07-isdirempty-eof
branch
from
August 21, 2026 11:09
3f9e2ab to
c6e3065
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any Readdirnames error was reported as (true, nil) and fed directory deletion. Only io.EOF now means empty.
Part of the stacked bugfix series fix/00 → fix/20; based on
fix/06-languages-empty-codes.🤖 Generated with Claude Code