Fix language lookups: empty-code collisions and unchecked map access - #488
Open
KillerX wants to merge 3 commits into
Open
Fix language lookups: empty-code collisions and unchecked map access#488KillerX wants to merge 3 commits into
KillerX wants to merge 3 commits into
Conversation
KillerX
force-pushed
the
fix/06-languages-empty-codes
branch
from
August 21, 2026 10:59
3e8a3b4 to
db959d9
Compare
ByISO6392TwoLetter (and ByISO6391) put entries with empty codes into the
map, so LanguagesByISOTwoLetter[""] resolved to whichever language was
last in the list and ParseLanguageCode("") succeeded instead of
returning ErrLanguageParsingFailed. LanguageKeysToOrderedLanguages
silently mapped unknown keys to a zero-value Language that sorts like
Norwegian; it now panics naming the offending key.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Callers pass both two- and three-letter codes, so the direct LanguagesByISO lookup rejected valid two-letter keys. The many-languages test also used "sv", which does not exist in the language table and was only passing via the old zero-value fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
KillerX
force-pushed
the
fix/06-languages-empty-codes
branch
from
August 21, 2026 11:09
db959d9 to
8126839
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ParseLanguageCode("") returned Swahili with nil error (three entries share an empty two-letter key); LanguageKeysToOrderedLanguages silently returned zero-value languages on a miss. Empty keys are now skipped, keys resolve via ParseLanguageCode (handles two- and three-letter codes), unknown keys panic loudly.
Part of the stacked bugfix series fix/00 → fix/20; based on
fix/05-vidispine-stream-ids.🤖 Generated with Claude Code