Repository navigation
Stop ConjugateGradientSolver from inverting A on every solve - #32
Merged
Merged
Conversation
…verse
Stop measuring convergence with an A^{-1}-based residual that required a
full invert on every solve. Use ||r|| against eps, and default maxIterations
to 2*n so larger SPD systems can finish.
Co-authored-by: Barry G Becker <barrybecker4@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13
ConjugateGradientSolver.solveno longer builds a full inverse ofAto measure convergence. It stops when the residual norm||r||falls beloweps, which keeps each iteration to matrix–vector products instead of anO(n³)invert.The default iteration limit is now
2 * nfor ann × nsystem (still overridable withsetMaxIterations), so classic CG can finish larger SPD problems that previously hit the hard cap of 8. Existing mismatch-size and low-max-iteration tests are unchanged; a 12×12 diagonal SPD case covers the new residual / default-limit behavior.