Repository navigation
Make unused constructor vars into vals - #26
Merged
Merged
Conversation
FunctionInverter.functionMap and ConjugateGradientSolver.matrix/b were public vars with no in-class or downstream reassignment callers. Public vals keep getters and only remove setters. Co-authored-by: Barry G Becker <barrybecker4@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructor parameters that are never reassigned are now
valinstead ofvar:FunctionInverter(functionMap)ConjugateGradientSolver(matrix, b)Getters remain public; only reference reassignment after construction is removed. Array contents for
functionMapstay mutable as before.No in-repo or downstream bb4 callers were found that assign to these fields. Making them private would hide the getters, so public
valis the smaller API-safe change.Fixes #19