Repository navigation
Deprecate MathUtil.RANDOM shared mutable generator - #24
Merged
Merged
Conversation
Keep the shared generator for downstream bb4 callers; document that it is seeded with 1, is not thread-safe, and that callers should prefer a local Random when isolation or concurrency matters. Co-authored-by: Barry G Becker <barrybecker4@yahoo.com>
Keep the public field so existing callers still compile, but mark it @deprecated since 2.1 so consumers get a compiler/IDE warning to use their own Random instead of the shared mutable fixed-seed instance. Co-authored-by: Barry G Becker <barrybecker4@yahoo.com>
cursor
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
MathUtil.RANDOMas@deprecated(since 2.1) while keeping the public field so existing callers still compile.RANDOMis a shared mutable fixed-seed (1)scala.util.Randomand is not thread-safe. The deprecation message, Scaladoc, and README direct consumers to construct their ownRandomwhen they need isolation, a different seed, or concurrent access.Searched this repo and the bb4 org for
MathUtil.RANDOM: unused inside bb4-math, but widely used by bb4-games, bb4-puzzles, bb4-simulations, and bb4-optimization, so it was kept and deprecated rather than removed.Fixes #22