Repository navigation
Conversation
With FC-NVMe enabled ESXi lists every Fibre Channel port twice, once as a SCSI adapter and once as an NVMe adapter (vmhba64 and up) with the same PCI address and port WWN. Both became interfaces, so each port showed up twice in NetBox. The vc001 capture has exactly this layout and the test asserted the duplicates. Keep one adapter per port (WWN and PCI address) and prefer the SCSI one. An NVMe adapter without a SCSI counterpart is still synced, and the skipped twin is logged at DEBUG2. Also treat a WWN of 0 as missing. pyVmomi reads an unset WWN as 0, which created an interface with WWN 00:00:00:00:00:00:00:00 instead of skipping the adapter as the option description says.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With FC-NVMe enabled, ESXi lists every Fibre Channel port twice: as a SCSI adapter and as an NVMe adapter (vmhba64 and up) with the same PCI address and port WWN.
sync_host_fc_adaptersturned both into interfaces, so each port showed up twice in NetBox (reported in #343). Our own vc001 capture has exactly this layout, and the test asserted the duplicates, which I didn't catch in #591.Tested with the vcsim captures and NetBox 4.7.2: a run on development creates 8 FC interfaces on a host with 4 ports, a run with this branch on top keeps vmhba3-6 untouched and tags vmhba64-67 as orphaned, and a second run changes nothing.