Repository navigation
tests: query the network hints the way vCenter answers - #587
Merged
Merged
Conversation
vcsim ignores the device argument of QueryNetworkHint(), so the suite could not tell that "" makes vCenter raise NotFound (#580). The test answers the call like vCenter does and fails on a device name the host does not have. The comments claiming the captures carry no CDP/LLDP data were wrong: vc001 records CDP neighbors, their switches are just not in NetBox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vcsim ignores the device argument of
QueryNetworkHint(), which is why the suite was green with the""from #350 and did not notice #580. The test answers the call like vCenter does, withNotFoundfor a device name the host does not have, and fails ondevelopmentbefore #581 with['', '', ''].The single call with
""came back in #565, where I replaced the per-NIC calls of #535 with it and checked against vcsim only; this is the check that was missing.Also corrects two comments in the file which claimed the captures carry no CDP/LLDP data: vc001 records CDP neighbors, their switches are just not in NetBox, which is why no cable comes out of the vcsim run.