Repository navigation
Test only the current server and SDK together - #64
Merged
Merged
Conversation
Weir has no users to stay compatible with, so a server and its clients can change together. Drop the version-skew job, its pin check, the previous pins and their Make targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weir has no users yet, so a server and its clients can change together and nothing needs to stay compatible with the version before. This drops the version-skew job that ran the integration suite against the previous server and the previous SDK, together with the pins, Make targets and guide text that existed only for it. The blackbox job still runs the full integration suite and the comparison smoke tests against the current pins.
Validated with
go vet(with and without the integration tag),go test ./...and the Python script tests. No!previousbuild constraints remained after #63, so no test changes are needed.