Repository navigation
Let one Execute message carry several requests or responses - #24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Weir spent about a third of its CPU sending and receiving a gRPC message per record. Each Execute message now carries one or more of the existing requests or responses, and a peer handles each element exactly as if it had arrived alone, so senders can pack whatever they have ready into one message. In local runs the server sends about seven results per message and the SDK about four records per message.
The element messages are unchanged; the new envelope validators only check that a message is non-empty and has no unknown fields of its own. This is a breaking wire change, released as v0.17.0.