Repository navigation
Remove Store discovery from the public protocol - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients now send Execute straight to a Weir server that hosts the Store, so the public service no longer needs a discovery RPC. This removes
ResolveStore, its messages and the endpoint helpers only discovery used, and defines NOT_FOUND as the status a server returns for a Store it does not host. The DNS transport helpers move into the server, the only remaining user, so this module is just schemas and validation.The README now says servers may bound the size of one message, matching Weir's per-message cap. weir-go and weir follow on the released version.