Keep the TUI socket tests under macOS's socket path cap - #401
Merged
Conversation
A unix socket path may be at most 104 bytes on macOS, and the open-remote tests bound theirs inside t.TempDir(), which embeds the test name in an already long per-user temp path. The three tests failed on every Mac and passed on Linux CI, and since the release preflight runs the unit tests locally, releasing from a Mac was blocked too. A short directory straight under the temp root stays well inside the cap on either platform, and is how Go's own net tests place theirs.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test-only change has no unresolved issues.
Pull request overview
Shortens Unix socket paths in TUI tests to comply with macOS limits.
Changes:
- Creates a short, private temporary runtime directory.
- Registers automatic cleanup.
File summaries
| File | Description |
|---|---|
internal/tui/open_remote_unix_test.go |
Uses a macOS-safe temporary socket path. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three open-remote tests in
internal/tuibind a unix socket undert.TempDir(). On macOS that path embeds the test name inside the long per-user temp dir and lands around 115 bytes, over the 104-bytesun_pathcap, so they fail withbind: invalid argumenton every Mac while passing on Linux CI. That also fails the local release preflight, sincemake releaseruns the unit tests before tagging.The helper now makes a short directory straight under the temp root with
os.MkdirTemp("", "hey")and cleans it up itself, the way Go's ownnettests place their sockets. Only this helper feeds a bind; the file's other twot.TempDir()uses compute or reject paths and are unchanged.