Pick the bubble test's future date relative to today - #400
Merged
Conversation
TestBubbleUpAndPop schedules a bubble-up "on a date" using a literal that was in the future when the test was written. The command sends a date that is today as the today slot rather than a custom date, so the day the literal arrived, both cases failed on every branch.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused test correction is consistent and has no unresolved issues.
Pull request overview
Updates the bubble scheduling test to remain valid over time.
Changes:
- Computes the future test date as seven days from execution.
- Reuses that date in request and summary assertions.
[!TIP]
If you aren't ready for review, convert to a draft PR. Click "Convert to draft" or rungh pr ready --undo. Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
internal/cmd/bubble_test.go |
Replaces an expired hardcoded date with a relative future date. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TestBubbleUpAndPop hardcoded 2026-09-04 as a future date. Today is 2026-09-04, so
hey bubble up --oncorrectly files it under the today slot and the two "on a date" cases fail on every branch, including #399. The date is now computed a week out from the test's run.