Repository navigation
feat: rename RootConnectionAuth for Backstage 1.54.0 - #161
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import type { - RootConnectionAuth + ConfiguredConnectionAuth } from '@backstage/connections'; -type Auth = RootConnectionAuth<MyMethod>; +type Auth = ConfiguredConnectionAuth<MyMethod>;AST provenance limits edits to the Connections binding; aliases, generic arguments, re-exports, inline import types, and namespace members are covered. Unaliased re-exports deduplicate across statements; removed declarations preserve inline comments.
/configremains a 1.55 migration. Minor changeset. Closes #145.Evidence
ec94018:as/satisfiesinline import types remained stale; alias plus unaliased import/export duplicatedConfiguredConnectionAuth; removing sole//-commented export swallowed next inline statement.After (
44e7216,b877ad7): 25/25 package fixtures pass, including generic constraints and EOF line-comment preservation. Runtime import expressions,/config, and foreign sources remain unchanged. AST-bound references preserve aliases; removed statements retain comments and terminating newline. Workflow validates withbase_path: '.'.32a67da,yarn format,yarn format:check,yarn lint,yarn test,yarn check:changed, packageyarn test, andgit diff --checkpass locally. Workflow dry-runs completed on the 25 input and expected fixtures; JSSG dry-run changed 24/25 inputs and made zero changes to 25/25 expected fixtures (0.054s). Earlier representative dry-runs: no-op 0.013s, real assertion migration 0.014s (single-run timings, not a benchmark).32a67da) documents source-qualified scope, exclusions, Yarndlxpreview/apply, and development checks.yarn dlx codemod@latest run --helpconfirms--targetand--dry-run; minor changeset included.ec94018workflow on 503-file mostly inert corpus (including excludeddist/): 2.07s vs same-entry no-op 1.96s; two files matched. Clean Backstage QA checkout0863f0349c63workflow dry-run: 4.2s; zeroRootConnectionAuthTS/TSX matches, zero expected edits; checkout stayed clean.Merge Danger
Door: two-way
Revert restores the prior codemod; no release or publication performed by this PR.
Blast Radius: type-imports
Only matched
@backstage/connectionstype bindings and their references change. Review aliases, namespace cases, and inline import types in migrated consumers.