Repository navigation
Add s3-access-denied-resolver skill - #302
Open
saadnu-aws wants to merge 1 commit into
Open
saadnu-aws wants to merge 1 commit into
saadnu-aws wants to merge 1 commit into
Conversation
Add a read-only skill that walks the ten layers that can deny an S3 request, names the denying layer and statement, and proposes the smallest fix as a diff for human review.
This PR is on hold — checklist incompleteRequired items in the PR description are unchecked. A maintainer will not review this PR until each one is checked and actually done. The check's summary lists them. Complete the work, tick the boxes, and this clears automatically. CONTRIBUTING.md explains each item. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
s3-access-denied-resolver, a read-only skill that diagnoses an Amazon S3 403 AccessDenied. A single S3 request can be denied by any of ten layers (SCP/RCP, VPC endpoint policy, Block Public Access, bucket policy, access point policy, identity policy, permissions boundary, session policy, Object Ownership/ACLs, KMS key policy), and the error message often does not say which. The skill reads each layer, assigns one verdict from a closed set (DENIED_BY,WOULD_ALSO_DENY,ALLOWED_BUT_UNVERIFIABLE,CANNOT_DETERMINE,NOT_APPLICABLE), names the denying layer and statement, and proposes the smallest fix as a diff for the operator to review. It uses IAM policy simulation only as corroboration, because simulation does not evaluate VPC endpoint or session policies. When the Agent Space refuses bucket-level S3 reads, it falls back to AWS Config, the owning CloudFormation stack and CloudTrail, and says which source each verdict rests on.Type of change
Required before review
skills/s3-access-denied-resolver/.Testing
structurechecks pass (12/12).best-practicesrun across 3 iterations, all passing.functionalrun with and without the skill, 3 iterations per scenario.evals/evals.jsonincludes 6 positive cases and 4 negative cases.Functional results (with skill vs. without):
bucket/*GetBucketPolicy,GetBucketEncryption,GetBucketOwnershipControls,GetPublicAccessBlock) were refused as "blocked by policy" in many runs, and added IAM permissions did not reliably lift it. The skill then reportsCANNOT_DETERMINEinstead of guessing, or uses the fallback sources. The README documents this and the extra read actions the fallbacks need.Skills
SKILL.mdfrontmatter is valid (88-line body).descriptionis written from the agent's point of view: error messages, API calls, symptoms.CHAT, INCIDENT_RCA.references/and load on demand.Security and safety
HeadObjectread is flagged in the README becauses3:GetObjectcan also read contents.License confirmation