Repository navigation
feat(connectors): add Terraform remote MCP connector - #286
gautambaghel wants to merge 3 commits into
Conversation
|
@thrashr888 — would you please review this connector for technical accuracy on the remote Terraform MCP and HCP Terraform behavior? In particular, please verify the US-only remote endpoint scope, bearer-token flow, beta caveat, and the documented read/write and run-approval boundaries. A comment or review identifying what you checked would provide the requested SME sign-off. Thank you! |
yeremyjt
left a comment
There was a problem hiding this comment.
Thanks, Gautam! This passes our connector checks and our publish step on this commit. Two requests below: one on the README and one on maintainers.
| ## Optional: install HashiCorp Terraform Agent Skills | ||
|
|
||
| HashiCorp's Terraform Agent Skills are separate from this connector and are not installed into AWS DevOps Agent by connecting it. Browse the official [HashiCorp Agent Skills repository](https://github.com/hashicorp/agent-skills) and its [Terraform skill catalog](https://github.com/hashicorp/agent-skills/blob/main/SKILLS.md), then install skills into a compatible client as needed. For example: | ||
|
|
||
| ```sh | ||
| npx skills add hashicorp/agent-skills/plugins/terraform/skills/terraform-style-guide | ||
| npx skills add hashicorp/agent-skills/plugins/terraform/skills/terraform-test | ||
| npx skills add hashicorp/agent-skills/plugins/terraform/skills/terraform-stacks | ||
| ``` | ||
|
|
||
| For Claude Code, install the Terraform plugin bundle with: | ||
|
|
||
| ```sh | ||
| claude plugin marketplace add hashicorp/agent-skills | ||
| claude plugin install terraform@hashicorp | ||
| ``` | ||
|
|
||
| See the Agent Skills repository for current instructions for other compatible clients. The skills are maintained and licensed by HashiCorp under that repository's license; this connector does not copy or redistribute their content. | ||
|
|
There was a problem hiding this comment.
Could this section come out? The console shows this README next to the connection form, so it should cover only the steps in HCP Terraform before connecting (Section 5 of the Connector Guide for Partners). DevOps Agent can only read skills from this repository's skills/ directory, so skills installed in other clients don't reach it. If you'd like DevOps Agent to use Terraform skills, you can add them under skills/terraform-<skill>/ and list them in connector.yaml (Section 6).
| ## Optional: install HashiCorp Terraform Agent Skills | |
| HashiCorp's Terraform Agent Skills are separate from this connector and are not installed into AWS DevOps Agent by connecting it. Browse the official [HashiCorp Agent Skills repository](https://github.com/hashicorp/agent-skills) and its [Terraform skill catalog](https://github.com/hashicorp/agent-skills/blob/main/SKILLS.md), then install skills into a compatible client as needed. For example: | |
| ```sh | |
| npx skills add hashicorp/agent-skills/plugins/terraform/skills/terraform-style-guide | |
| npx skills add hashicorp/agent-skills/plugins/terraform/skills/terraform-test | |
| npx skills add hashicorp/agent-skills/plugins/terraform/skills/terraform-stacks | |
| ``` | |
| For Claude Code, install the Terraform plugin bundle with: | |
| ```sh | |
| claude plugin marketplace add hashicorp/agent-skills | |
| claude plugin install terraform@hashicorp | |
| ``` | |
| See the Agent Skills repository for current instructions for other compatible clients. The skills are maintained and licensed by HashiCorp under that repository's license; this connector does not copy or redistribute their content. |
There was a problem hiding this comment.
Removed the optional Agent Skills install section. I left the rest of the README unchanged.
| docs_url: https://developer.hashicorp.com/terraform/mcp-server/deploy/remote-mcp | ||
| support_url: https://www.ibm.com/mysupport | ||
| contact_email: hashicorp.security@ibm.com | ||
| maintainers: [hashicorp/team-agent-skills-ecosystem] |
There was a problem hiding this comment.
Could you list individual GitHub users here instead of the team? This is a new requirement from our security team: maintainers holds only GitHub usernames, not teams, and the pull request author must be one of them. You can add up to four more HashiCorp maintainers by username.
| maintainers: [hashicorp/team-agent-skills-ecosystem] | |
| maintainers: [gautambaghel] |
There was a problem hiding this comment.
Updated maintainers to [gautambaghel], an individual GitHub username and the PR author.
|
Thanks for the review @yeremyjt, I made the changes as you requested! |
Description
Adds a partner-managed Terraform connector for HashiCorp's hosted remote Terraform MCP server, plus a customer setup guide covering bearer-token authentication, HCP Terraform access boundaries, beta/region limitations, and read-only-first use. This PR adds no Agent Skills or skill files.
The new connector starts at
1.0.0. It is not added toconnectors/releases.yaml, which is maintained by AWS maintainers and controls production promotion.Type of change
Required before review
gautambaghelis listed as the connector maintainer.Testing
python3 -m unittest discover -s tests -v— 348 tests passed.mkdocs build --strict— passed.python3 .github/scripts/validate_skills.py --base-ref upstream/main— 103 skills checked, 0 errors. The local shallow clone cannot check previously retired skill paths; no skills are changed here.python3 .github/scripts/scan_aws_identifiers.py --base-ref upstream/main --head-ref HEAD— 0 findings.1.0.0connector; light and dark logos pass the repository's logo safety check.initializerequest tohttps://mcp.terraform.io/mcpreturned401 Authorization bearer token is required, as expected.tools/list(56 tools),whoami,list_terraform_orgs,get_token_permissions,list_workspaces, and a public AWS provider lookup all passed. Credentials and returned identity, organization, permission, and workspace data were not included in the PR. No mutative tools, runs, or applies were invoked.git diff --check— passed.SME review
Paul Thrasher (
@thrashr888), HCP Terraform, approved commitcceb282. That approval predates this follow-up commit, which only removes the optional Agent Skills section and updates the maintainer username.Connectors
License confirmation
Closes #285