-
Notifications
You must be signed in to change notification settings - Fork 94
feat(eval): grouped help and command examples for the eval commands #2262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
+361
−80
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7538097
feat(router): add help groups and command examples
4912e18
feat(eval): group and document the eval command help
4d9616b
refactor(eval): drop the examples mechanism and the shared group voca…
c8936e9
refactor(eval): name each command's help-group headings with consts
e580808
refactor(eval): inline help-group headings used only once
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| export const onlineEvalDataSourceConfigHelp = `(JSON: tagged union object) | ||
| Which traces are sampled, for sources the --agent convenience flag cannot | ||
| express. Only top-level key: cloudWatchLogs. | ||
|
|
||
| Accepts inline JSON, file://<path>, or - to read stdin. | ||
|
|
||
| JSON syntax: | ||
| { | ||
| "cloudWatchLogs": { | ||
| "serviceNames": ["string", ...], // [required] e.g. "my_agent.DEFAULT" | ||
| "logGroupNames": ["string", ...], // exact group names | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The locked control-plane SDK does not support logGroupNamePrefixes; CloudWatchLogsInputConfig requires both logGroupNames and serviceNames. Following the documented prefix alternative sends no logGroupNames and fails service validation. |
||
| "logGroupNamePrefixes": ["string", ...] // or match by prefix instead | ||
| } // supply one of the two name lists | ||
| } | ||
|
|
||
| API reference: | ||
| https://docs.aws.amazon.com/bedrock-agentcore-control/latest/APIReference/API_DataSourceConfig.html | ||
|
|
||
| Example: | ||
| --data-source-config '{"cloudWatchLogs":{"logGroupNames":["/aws/bedrock-agentcore/runtimes/my-runtime-DEFAULT"],"serviceNames":["my_agent.DEFAULT"]}}'`; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| export const filtersHelp = `(JSON: list of objects) | ||
| Narrows which sampled traces are evaluated. A trace must match every filter in | ||
| the list. Omit it to evaluate every sampled trace. | ||
|
|
||
| Accepts inline JSON, file://<path>, or - to read stdin. | ||
|
|
||
| JSON syntax: | ||
| [ | ||
| { | ||
| "key": "string", // [required] trace field to filter on | ||
| "operator": "Equals" | "NotEquals" | "Contains" | "NotContains" | ||
| | "GreaterThan" | "GreaterThanOrEqual" | ||
| | "LessThan" | "LessThanOrEqual", // [required] | ||
| "value": { // [required] exactly one key | ||
| "stringValue": "string", | ||
| "doubleValue": number, | ||
| "booleanValue": true | false | ||
| } | ||
| }, | ||
| ... | ||
| ] | ||
|
|
||
| Example: | ||
| --filters '[{"key":"attributes.customer_tier","operator":"Equals","value":{"stringValue":"enterprise"}}]' | ||
|
|
||
| --filters file://filters.json`; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this documented shape doesn’t match SessionMetadataShape. groundTruth.inline must be an InlineGroundTruth object, not a string. The current example will produce an invalid API request. Could we update it to use a valid shape such as
{"inline":{"turns":[...]}}?