fix: mark logs and traces as cli only - #2250
Conversation
|
Claude Security Review: no high-confidence findings. (run) |
There was a problem hiding this comment.
AgentCore Harness Review
Verdict: Looks good
Small, focused change: registers supportedTuiCommands on the harness router so that logs and traces (which don't have screens) render below the "command line only" divider in the TUI menu, matching the pattern already used by runtime, gateway, eval, etc.
The test update is a nice touch — the new "the harness menu" case asserts the exact screens/CLI-only partition, and the pre-existing "divider is omitted" case is relocated to /agentcore/harness/endpoint, where every subcommand still has a screen, so the assertion is still meaningful.
No new user-facing feature here, so no telemetry gap. Nothing to change from my side.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #2250 +/- ##
=========================================
Coverage 97.04% 97.04%
=========================================
Files 566 566
Lines 39409 39420 +11
=========================================
+ Hits 38244 38255 +11
Misses 1165 1165 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Description
In our TUI,
logsandtracesare both appearing under harness as standard TUI items, though both are CLI-only commands.This PR updates the harness handler to exclude the above operations as TUI supported, adding the CLI-only line and styling for unsupported commands.
Example
agentcore-> running RC project installed via npmacr-dev-> running project from my dev environmentScreen.Recording.2026-09-09.at.9.08.02.AM.mov
Type of Change
Testing
How have you tested the change?
bun run test(3179 pass, 0 fail)npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.