Skip to content

fix: mark logs and traces as cli only - #2250

Open
nborges-aws wants to merge 1 commit into
refactorfrom
harness-logs-TUI-fix
Open

fix: mark logs and traces as cli only#2250
nborges-aws wants to merge 1 commit into
refactorfrom
harness-logs-TUI-fix

Conversation

@nborges-aws

Copy link
Copy Markdown
Contributor

Description

In our TUI, logs and traces are both appearing under harness as standard TUI items, though both are CLI-only commands.

This PR updates the harness handler to exclude the above operations as TUI supported, adding the CLI-only line and styling for unsupported commands.

Example

agentcore -> running RC project installed via npm
acr-dev -> running project from my dev environment

Screen.Recording.2026-09-09.at.9.08.02.AM.mov

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Other (please describe):

Testing

How have you tested the change?

  • bun run test (3179 pass, 0 fail)
  • I ran npm run test:unit and npm run test:integ
  • I ran npm run typecheck
  • I ran npm run lint
  • If I modified src/assets/, I ran npm run test:update-snapshots and committed the updated snapshots

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.

@github-actions github-actions Bot added the size/s PR size: S label Sep 9, 2026
@agentcore-devx-automation agentcore-devx-automation Bot added agentcore-harness-reviewing AgentCore Harness review in progress claude-security-reviewing Claude Code /security-review in progress labels Sep 9, 2026
@agentcore-devx-automation

Copy link
Copy Markdown
Contributor

Claude Security Review: no high-confidence findings. (run)

@agentcore-devx-automation agentcore-devx-automation Bot removed the claude-security-reviewing Claude Code /security-review in progress label Sep 9, 2026

@agentcore-devx-automation agentcore-devx-automation Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AgentCore Harness Review

Verdict: Looks good

Small, focused change: registers supportedTuiCommands on the harness router so that logs and traces (which don't have screens) render below the "command line only" divider in the TUI menu, matching the pattern already used by runtime, gateway, eval, etc.

The test update is a nice touch — the new "the harness menu" case asserts the exact screens/CLI-only partition, and the pre-existing "divider is omitted" case is relocated to /agentcore/harness/endpoint, where every subcommand still has a screen, so the assertion is still meaningful.

No new user-facing feature here, so no telemetry gap. Nothing to change from my side.

@agentcore-devx-automation agentcore-devx-automation Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Sep 9, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.04%. Comparing base (d9ab959) to head (a0b57a4).
⚠️ Report is 1 commits behind head on refactor.

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #2250   +/-   ##
=========================================
  Coverage     97.04%   97.04%           
=========================================
  Files           566      566           
  Lines         39409    39420   +11     
=========================================
+ Hits          38244    38255   +11     
  Misses         1165     1165           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/s PR size: S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants