fix(#585): parameterize remaining hardcoded values in addon charts (devlake, ray-system, keycloak) - #827
Merged
Conversation
allamand
requested review from
elamaran11,
hmuthusamy,
punkwalker and
shapirov103
as code owners
September 1, 2026 09:40
…arts
- devlake/external-secret.yaml: remoteKey peeks-devlake/mysql-connection ->
{{ .Values.resourcePrefix | default "peeks" }}-devlake/mysql-connection
(aligns with the grafana-dashboards sibling that reads the same SM secret)
- platform-manifests/ray-system-iamroleselectors.yaml: peeks-cluster-mgmt-{iam,eks}
-> {{ .Values.global.resourcePrefix | default "peeks" }}-cluster-mgmt-*
- keycloak/keycloak-config.yaml: replace the hardcoded EKS kubectl URL
(s3.us-west-2 + pinned 1.32.0 + build date) with the repo-standard
dl.k8s.io/release/stable pattern used everywhere else (cicd-pipeline, kubeflow) --
removes the hardcoded region AND the version pin, no renovate customManager needed.
Behaviour-preserving (devlake/ray use '| default'). KRO resource-groups manifests
(appmod-service.yaml, ray-service.yaml) left to #597.
allamand
force-pushed
the
fix/585-remove-hardcoded-values
branch
from
September 1, 2026 12:42
4b9ec39 to
ad7b47e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Parameterizes / removes the remaining hardcoded
peeks/us-west-2/ pinned values in the non-KRO addon charts flagged by #585:devlake/templates/external-secret.yaml(x2)peeks-devlake/mysql-connection{{ .Values.resourcePrefix | default "peeks" }}-devlake/mysql-connectionplatform-manifests/templates/ray-system-iamroleselectors.yaml(x2)role/peeks-cluster-mgmt-{iam,eks}role/{{ .Values.global.resourcePrefix | default "peeks" }}-cluster-mgmt-{iam,eks}keycloak/templates/keycloak-config.yamlcurl ... s3.us-west-2.amazonaws.com/amazon-eks/1.32.0/2024-12-20/.../kubectlcurl ... dl.k8s.io/release/$(curl -L -s https://dl.k8s.io/release/stable.txt)/.../kubectlWhy
| default "peeks", so rendering is byte-identical when unset (no behavior change on existing deployments). devlake is aligned with thegrafana-dashboardssibling that reads the same SM secret.1.32.0coupled to an EKS build date (2024-12-20) — not renovate-trackable (a version bump would leave a broken date). Switched to thedl.k8s.io/release/stablepattern already used everywhere else in the repo (cicd-pipeline x5, kubeflow) → removes the hardcoded region and the version pin, always fetches the current stable kubectl, no renovate customManager needed, and makes the repo consistent.Verified live (read-only) on kro-c1 that these were the charts still carrying hardcoded values; already-fixed items (backstage
system-peeks, huggingface-models, image-prepuller, grafana-dashboards) confirmed clean.Deferred / for discussion
kro/.../appmod-service.yaml:peeks-cluster-mgmt-*,key: peeks/platform/amp;kro/.../ray-service.yaml) — left to KRO resource groups — align naming with clusterName #597 (resourcePrefix -> clusterName alignment). Thepeeks/us-west-2values there that are KRO schema defaults are explicitly allowed by Remove hardcoded static values from addon charts #585's acceptance.Partially addresses #585 (non-KRO charts); KRO portion tracked in #597.