Repository navigation
fix(graphql-docs-generator): allow handlebars ^4.7.10 - #1039
Draft
sharonyajain wants to merge 1 commit into
Draft
sharonyajain wants to merge 1 commit into
sharonyajain wants to merge 1 commit into
Conversation
handlebars 4.7.10 fixes GHSA-8r5x-fm3f-whwj, GHSA-p8wg-vrv2-v86f (critical) and GHSA-xw65-4hp5-5hc7. The docs generator pinned exactly 4.7.9, so consumers could not pick up the fix. - graphql-docs-generator: handlebars 4.7.9 -> ^4.7.10 - root resolutions: handlebars >=4.7.9 -> >=4.7.10 - yarn.lock: handlebars 4.7.10 (minimist ^1.2.8) The docs generator registers only string partials and iterates arrays in #each, so the 4.7.10 compatibility notes do not apply. graphql-docs-generator and graphql-generator tests pass with unchanged snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
@aws-amplify/graphql-docs-generatorpinnedhandlebarsto exactly4.7.9. This change moves it to^4.7.10, the first release that fixes GHSA-8r5x-fm3f-whwj (critical), GHSA-p8wg-vrv2-v86f (critical) and GHSA-xw65-4hp5-5hc7 (moderate). With the exact pin, consumers could not pick up the fix, andnpm auditreports "No fix available" for every Gen 2 project throughform-generatorandgraphql-generator.packages/graphql-docs-generator/package.json:handlebars4.7.9→^4.7.10.resolutions:handlebars>=4.7.9→>=4.7.10, so the monorepo's security floor matches the new pin.yarn.lock:handlebars4.7.10, and minimist^1.2.8, which 4.7.10 requires and which was already locked at 1.2.8.The 4.7.10 compatibility notes (release notes) don't affect this package:
getTemplatePartials()).{{#each}}iterates Map/Set/generators lazily. The templates iterate only plain arrays (args,fields, ...).Release note: lerna's
--exactpublish bumps the exactgraphql-docs-generatorpins ingraphql-generatorandamplify-codegen. amplify-backend depends on these packages through caret ranges (form-generator:^4.1.0;backend-data/model-generator:graphql-generator ^0.5.1), so a fresh install ornpm updatepicks up the fix with no amplify-backend release.Note for reviewers: running plain
yarn installon unmodifiedmainalready rewritesyarn.lock. It re-adds a@aws-amplify/graphql-docs-generator@4.2.1entry and splitsjs-yaml@^3.10.0. That drift predates this change, so I left it out of this PR.Codegen Paramaters Changed or Added
None.
Issue #, if available
N/A
Description of how you validated changes
yarn install --frozen-lockfilepasses with the updated lockfile.packages/graphql-docs-generator:yarn buildpasses;yarn test: 11 suites, 48 tests, 6 snapshots passed.packages/graphql-generator(built with its dependencies; holds the generated statements/types/models snapshots):yarn test: 6 suites, 50 tests, 42 snapshots passed. Generated output is unchanged with 4.7.10.Checklist
yarn testpasses (graphql-docs-generator and graphql-generator)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.