Repository navigation
ci(swift-modelgen): bump canary toolchain to Xcode 26 / Swift 6 - #1038
Merged
Merged
Conversation
amplify-swift 2.62.0 adopted the Swift 6 language mode (swiftLanguageModes flipped from [.v5] to [.v6]), so it now requires a full Swift 6 strict-concurrency build. The canary was running Xcode 16.1 / Swift 6.0.2 on the macos-14 image, which cannot build it cleanly, breaking every run since 2026-09-23 (see P520055368). Bump runs-on to macos-15-xlarge and select Xcode 26.1 so the canary builds the current Swift-6 SDK the way customers on current Xcode do, rather than pinning the SDK back to the Swift-5-language-mode 2.61.0.
harsh62
approved these changes
Sep 24, 2026
svidgen
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the iOS codegen canary (P520055368), which has failed 100% of runs since 2026-09-23 ~19:00 UTC.
What broke
The
build-swift-modelgen.ymlcanary builds a small Swift app againstamplify-swifton every run. The app pinsfrom: "2.12.0", so SPM always resolves the newest release.swiftLanguageModes: [.v5]— built under Swift 5 language rules even on a Swift 6 compiler, so it compiled cleanly on the canary's Xcode 16.1 / Swift 6.0.2 runner.swiftLanguageModes: [.v6]— its headline feature is "core: adopt the Swift 6 language mode." The package now requires a full Swift 6 strict-concurrency build.The canary's toolchain (Xcode 16.1 / Swift 6.0.2 on
macos-14) is behind what a clean Swift 6 build wants, soemit-modulefails with ~100 Sendable / explicit-selferrors in amplify-swift's own source. All 8 consecutive failures are byte-identical; the toolchain was unchanged across the green→red boundary — only the SDK version changed.The fix
Bump the canary toolchain rather than pin the SDK back:
runs-on: macos-14-xlarge→macos-15-xlarge(the macos-15 image carries Xcode 26.x).Xcode_16.1.0.app→Xcode_26.1.app(26.1.1; avoids the missing-Swift-runtime regression tracked for 26.0.1 in Xcode 26.0.1 Seems to be missing Swift Runtime Components actions/runner-images#13135).This keeps the canary honest — it builds the current Swift-6 SDK the way customers on current Xcode do — instead of masking the migration by pinning amplify-swift to the Swift-5-language-mode 2.61.0.
Testing
Toolchain/CI-only change; validated via the run history and per-run logs on P520055368. The workflow is
workflow_dispatch(manual, driven by the CodeBuild canary), so a green run after merge confirms the fix.