Repository navigation
fix: serialize compaction and preserve messages written mid-summarization - #1889
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race in
compactAgentContextwhere messages written to the thread during the slow summarization step were wiped by the replace-allupdateState, leaving the agent echoing its last statement. Compactions are now serialized per thread, and the state is re-read before the write so newly arrived messages are carried over.Type of Change
Testing
Added two unit tests in
tests/unit/deepAgents.test.js: one verifying a message arriving mid-compaction is preserved, one verifying concurrent compactions on the same thread run in order. All 31 tests in the file pass. The narrowed window between the re-read andupdateStateremains, and the middleware-triggered path is not locked against a live run.Coverage
Checklist
npm run lintpasses