Skip to content

feat: nudge assistant to stay quiet when silent mode streams a second message - #1885

Merged
avoidwork merged 2 commits into
mainfrom
feat/silent-mode-nudge
Nov 18, 2026
Merged

avoidwork merged 2 commits into
mainfrom
feat/silent-mode-nudge

Conversation

@avoidwork

@avoidwork avoidwork commented Nov 18, 2026 •

Copy link
Copy Markdown
Owner

Description

When agent.silent is true and a second text-bearing assistant message starts streaming in the same turn, the stream is abandoned before that text renders and a hidden nudge, "Stay quiet, silent mode is enabled", is sent to the assistant. The nudge reuses the existing silent "Continue" / "You're looping" pattern, but it corrects behavior rather than continuing a turn, so it is not counted against autoContinueLimit.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor (no functional changes)
  • Performance improvement
  • CI / build / tooling

Testing

Added tests/unit/stream/silentMode.test.js (11 tests). It covers consumeStream silent detection (second message abandons the stream without forwarding its text, chunks of one message are not flagged, tool-call-only messages and subagent messages are ignored, nothing is flagged when silent is off) and shouldNudgeSilent (violation, interrupted turn, non-last bubble, not bound by the auto-continue limit, nudge text). The full suite and coverage ran green via the pre-commit hook. The behavior has not been exercised in the live TUI.

Coverage

  • Line coverage maintained

Checklist

  • npm run lint passes
  • Tests pass with maintained line coverage
  • No forbidden patterns used
  • Conventional Commit style applied

Threat model

N/A. No new inputs, I/O, or network calls. The nudge is a fixed constant string, gated by an existing config flag.

… message

When agent.silent is true and a second text-bearing assistant message starts
in the same turn, abandon the stream before that text renders and send the
hidden nudge 'Stay quiet, silent mode is enabled'. Bounded by autoContinueLimit.
@avoidwork avoidwork self-assigned this Nov 18, 2026
The nudge corrects behavior rather than continuing a turn, so it no longer
increments autoContinueCountRef or checks the auto-continue limit.
@avoidwork
avoidwork merged commit 3312651 into main Nov 18, 2026
2 checks passed
@avoidwork
avoidwork deleted the feat/silent-mode-nudge branch November 18, 2026 04:29
@avoidwork avoidwork mentioned this pull request Nov 18, 2026
3 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant