fix: propagate read errors from getKeyPress instead of busy-looping - #16
Open
ruslsalimov wants to merge 2 commits into
Open
ruslsalimov wants to merge 2 commits into
ruslsalimov wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15
getKeyPressturned every error frominputTTY.Readinto an emptykeys.Key{}with anilerror.When the terminal goes away (window closed,
SIGHUPnot delivered or ignored),readon/dev/ttyreturns
EIOimmediately and forever, soListenspins at 100%+ CPU and never returns.Measurements, debugger output and the commit history behind the swallowing are in the issue.
Changes
getKeyPressreturns the read error, as the original 2022-06-01 code did.Listendecides what a read error means: ifstopRoutineis already set —stop()sets itbefore closing/cancelling the fd — the read was interrupted by our own stop (
Closeon Unix,CancelIoExon Windows) and it is a normal shutdown; otherwiseListenrestores the console(
stop()+stopListener()) and returns the error.