Skip to content

build(reactjs)!: restore identity link tests and publish ESM - #167

Merged
TorinAsakura merged 4 commits into
masterfrom
chore/remove-obsolete-tooling
Oct 8, 2026
Merged

TorinAsakura merged 4 commits into
masterfrom
chore/remove-obsolete-tooling

Conversation

@TorinAsakura

@TorinAsakura TorinAsakura commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

Task

  • Refs atls/infrastructure#1588
  • Remove root tooling duplicated by Raijin and check dependency declarations without a skip flag
  • Restore the five identity-link URL scenarios that were commented out and ignored
  • Publish @atls/react-identity-links as ESM with a major release; CommonJS consumers can remain on 0.x until migrated

How to verify

  1. On the previous head, inspect the two deleted test files in master: all five scenarios were commented out, and testIgnorePatterns hid the files. On this head, the files contain executable Node tests and the ignore entries are absent
  2. With Node 24, run HUSKY=0 yarn install --immutable and yarn check --verify. The lockfile remains unchanged; formatting, lint, declaration checking, 15 unit tests and one integration test pass
  3. Run yarn workspaces foreach -A --topological-dev run build. All workspaces build; @atls/react-identity-links/dist/index.js can be imported as ESM
  4. Run yarn version check and yarn version apply --all --dry-run. Yarn selects @atls/react-identity-links@1.0.0 and @atls/react-kratos@0.1.2
  5. Run yarn workspace @atls/react-identity-links pack --dry-run. The archive includes ESM JavaScript and declarations, and excludes compiled test files

Proofs

  • The identity-link component test and four hook tests pass on Raijin's Node test runner. The package's runtime import of CommonJS tldjs was updated for native ESM interop
  • Local immutable install, full check, all workspace builds, version check, release dry run and package archive inspection passed
  • The package emits ESM with explicit .js relative imports; Yarn selects the major 1.0.0 release

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T00:56:53.393125Z 69cb2d0 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Run the historical identity URL scenarios with Raijin's Node test runner.
Publish ESM with explicit JavaScript imports and exclude test output from
the package archive.

BREAKING CHANGE: @atls/react-identity-links now publishes ESM instead of CommonJS.
@TorinAsakura TorinAsakura changed the title chore(reactjs): remove obsolete tooling and disabled tests build(reactjs)!: restore identity link tests and publish ESM Oct 8, 2026
@TorinAsakura
TorinAsakura merged commit e3eff94 into master Oct 8, 2026
2 checks passed
@TorinAsakura
TorinAsakura deleted the chore/remove-obsolete-tooling branch October 8, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant