Repository navigation
build(reactjs)!: restore identity link tests and publish ESM - #167
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Run the historical identity URL scenarios with Raijin's Node test runner. Publish ESM with explicit JavaScript imports and exclude test output from the package archive. BREAKING CHANGE: @atls/react-identity-links now publishes ESM instead of CommonJS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
@atls/react-identity-linksas ESM with a major release; CommonJS consumers can remain on 0.x until migratedHow to verify
master: all five scenarios were commented out, andtestIgnorePatternshid the files. On this head, the files contain executable Node tests and the ignore entries are absentHUSKY=0 yarn install --immutableandyarn check --verify. The lockfile remains unchanged; formatting, lint, declaration checking, 15 unit tests and one integration test passyarn workspaces foreach -A --topological-dev run build. All workspaces build;@atls/react-identity-links/dist/index.jscan be imported as ESMyarn version checkandyarn version apply --all --dry-run. Yarn selects@atls/react-identity-links@1.0.0and@atls/react-kratos@0.1.2yarn workspace @atls/react-identity-links pack --dry-run. The archive includes ESM JavaScript and declarations, and excludes compiled test filesProofs
tldjswas updated for native ESM interop.jsrelative imports; Yarn selects the major 1.0.0 release