Repository navigation
fix(text): declare framer-motion runtime dependency - #780
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Таска
Как проверять
До фикса
Textиз@atls-ui-parts/text@1.1.1для приложения на React 19. Действие: собрать приложение с этим импортом. Ожидаемый результат: сборка останавливается на@atls-ui-parts/condition, которому нужен не предоставленный пакетом текстаframer-motion.После фикса
yarn install --immutable,yarn check --verify,yarn workspace @atls-ui-parts/text pack --out /tmp/text.tgzи прочитатьpackage/package.jsonиз архива. Ожидаемый результат: проверки проходят, у пакета текста есть runtime-зависимостьframer-motion: 12.43.0рядом с@atls-ui-parts/condition.yarn version check. Ожидаемый результат: проверка проходит; для@atls-ui-parts/textзаписан patch, для не изменённых потребителей —decline.Пруфы
@atls-ui-parts/text@1.1.1остановилась сModule not found: @atls-ui-parts/condition tried to access framer-motion (a peer dependency) but it isn't provided by its ancestors.yarn check --verify, package pack иyarn version checkзавершились успешно. Из собранного архива:{ "@atls-ui-parts/condition": "1.2.1", "framer-motion": "12.43.0" }text@1.1.1, безpackageExtensionsдля текста и без прямогоframer-motionв трёх фрагментах;yarn workspace @atls/grpc-playground-app run buildзавершился успешно. Временнаяfile:/tmp-ссылка после проверки удалена.