apps/app_chanspy: don't delay spyee Hangup when spy channel has no reverse media - #2124
Open
Tinet-mucw wants to merge 1 commit into
Open
apps/app_chanspy: don't delay spyee Hangup when spy channel has no reverse media#2124Tinet-mucw wants to merge 1 commit into
Tinet-mucw wants to merge 1 commit into
Conversation
…verse media channel_spy() waited indefinitely on the spy channel, so after the spyee hung up the spy audiohook leaving RUNNING was not noticed until waitfor timed out. That kept an autochan reference on the spyee and delayed its destructor / Hangup. Poll with a short timeout instead. On timeout, only re-check hook status; call ast_read() only when the spy channel is readable. Resolves: asterisk#2123
Contributor
Author
|
cherry-pick-to: 24 |
github-actions
Bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
Bot
added
the
has-pr-checklist
|
Workflow Check failed |
Tinet-mucw
changed the title
jcolp
approved these changes
Sep 1, 2026
gtjoseph
dismissed
github-actions[bot]’s stale review
September 1, 2026 12:32
Pull Request Checklist Complete
gtjoseph
added
cherry-pick-test
github-actions
Bot
added
cherry-pick-testing-in-progress
|
Workflow CPCheck failed |
Contributor
|
Possibly related to #68? I’m basing that purely on symptoms |
Member
|
I pondered that, but I don't think so. Separate issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
channel_spy() waited indefinitely on the spy channel, so after the spyee hung up the spy audiohook leaving RUNNING was not noticed until waitfor timed out. That kept an autochan reference on the spyee and delayed its destructor / Hangup.
Poll with a short timeout instead. On timeout, only re-check hook status; call ast_read() only when the spy channel is readable.
Resolves: #2123