feat: add path mapping support to webpack_bundle - #214
Merged
Conversation
acozzette
commented
Jul 30, 2026
acozzette
force-pushed
the
path-mapping
branch
3 times, most recently
from
July 30, 2026 22:57
07a07b0 to
08952cf
Compare
acozzette
marked this pull request as ready for review
July 31, 2026 21:46
jbedard
reviewed
Jul 31, 2026
jbedard
reviewed
Jul 31, 2026
Set the `supports-path-mapping` execution requirement on the Webpack action so that builds which differ only in compilation mode (e.g. -c fastbuild vs -c opt) can share a single cached action. Support is only advertised when none of the `env` values expand via location or Make variable expansion, since those can produce paths that aren't path mapped. Add an e2e test (e2e/path_mapping) that builds a webpack_bundle target under -c fastbuild then -c opt with a shared --disk_cache and asserts the second build's action is served from cache.
jbedard
approved these changes
Aug 7, 2026
jbedard
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the
supports-path-mappingexecution requirement on the Webpack action so that builds which differ only in compilation mode (e.g. -c fastbuild vs -c opt) can share a single cached action. Support is only advertised when none of theenvvalues expand via location or Make variable expansion, since those can produce paths that aren't path mapped.Add an e2e test (e2e/path_mapping) that builds a webpack_bundle target under -c fastbuild then -c opt with a shared --disk_cache and asserts the second build's action is served from cache.
Changes are visible to end-users: yes
Add path mapping support to webpack_bundle.
Test plan