Repository navigation
Conversation
2 of 7 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces #281, following the suggestion to collect required columns during query construction.
Field references and correlation keys are recorded as expressions and joins are built. The final pass uses this metadata to narrow implicit
from_many?selections, without re-scanning expression ASTs. When dependencies cannot be tracked reliably, the original selection is retained.I've updated the benchmark to compare the upstream base, #281's AST scan, and this implementation with identical dependencies and data.
For the latest Payment query:
The motivation remains easier-to-read SQL; PostgreSQL already prunes unused projections.
Execution integration is in ash-project/ash_postgres#919.
Contributor checklist
Leave anything that you believe does not apply unchecked.