Skip to content

test: reproduce incorrect parent detection in nested aggregates #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachdaniel merged 1 commit into from
Nov 3, 2026
Merged

test: reproduce incorrect parent detection in nested aggregates #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/aggregate_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@

attributes do
uuid_primary_key(:id)
attribute(:min_score, :integer)
end

relationships do
Expand All @@ -146,6 +147,7 @@

aggregates do
max(:highest_score, :comments, :score)
count(:high_score_comments, :comments, filter: expr(score >= parent(min_score)))
end

actions do
Expand Down Expand Up @@ -178,6 +180,13 @@
)
end

test "a parent in a nested aggregate filter does not prevent grouping" do

Check failure on line 183 in test/aggregate_test.exs

View workflow job for this annotation

GitHub Actions / ash-ci / mix test 

test a parent in a nested aggregate filter does not prevent grouping (AshSql.AggregateTest)
query = Ash.Query.filter(Post, high_score_comments > 0)
{:ok, aggregate} = Ash.Query.Aggregate.new(Post, :matching_posts, :count, query: query)

assert AshSql.Aggregate.can_group?(Post, aggregate, %Ecto.Query{})
end

describe "resource_aggregate_to_aggregate/3" do
test "passes actor and tenant to the related read which may require an actor" do
actor = %{id: Ash.UUID.generate()}
Expand Down
Loading