cmake: honour USE_STATGRAB - #263
Open
cruzzil wants to merge 1 commit into
Open
Conversation
The option was declared but never consulted, so the REQUIRED pkg-config check ran regardless and configure failed where libstatgrab is not packaged, with no way to opt out. The code already treats it as optional: HAVE_STATGRAB follows STATGRAB_FOUND, which stays unset on this path. Fixes asdf-format#262.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #262.
USE_STATGRABwas declared but never consulted, sopkg_check_modules(STATGRAB libstatgrab REQUIRED)ran regardless and-DUSE_STATGRAB=OFFcould not turn it off. On platforms where libstatgrab is not packaged, configure failed with no way out.HAVE_STATGRABalready followsSTATGRAB_FOUND, which stays unset on the new path, so the source needs no change.Checked both ways on Linux:
OFFskips the probe, builds, 22/22 tests; the default still finds 0.92.1, builds, 22/22.