Fixes for #251 - #254
Merged
Merged
Conversation
The former is simply wrong on LLP64 targets, while the latter is equivalent on both LP64 and LLP64 targets. Adapted from PR asdf-format#252 submitted by @cruzzil.
embray
force-pushed
the
issue-251
branch
3 times, most recently
from
September 8, 2026 10:09
e504f46 to
7d17358
Compare
Adapted from PR asdf-format#252 by @cruzzil, but instead of using ptrdiff_t simply define a semantically meaningful asdf_depth_t typedef simply as int64_t which should be safe ABI-wise.
Collaborator
Author
Contributor
|
Looks good, and agree your custom type is probably better for flexibility. |
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Alternative approach to #252. Mostly the same but with my own spin.
AI Disclosure
No AI tools used.