Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Warning Review limit reached
Next review available in: 10 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
📝 WalkthroughWalkthroughChangesSubagent takeover lifecycle
Estimated code review effort: 5 (Critical) | ~120 minutes Possibly related issues
Possibly related PRs
Suggested labels: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@apps/desktop/src/main/services/chat/agentChatService.ts`:
- Around line 29741-29752: Move the readTranscriptEnvelopes(child) and
mergeEnvelopeStreams call inside the parentShouldWake branch, so transcript
history is loaded only for subagent completions before
countHumanChildMessagesForTurn runs. Preserve the existing zero-count behavior
for peers and avoid any synchronous transcript read on the peer completion path.
In `@apps/ios/ADE/Views/Work/WorkSessionDestinationView.swift`:
- Around line 1583-1585: Gate role-transition callbacks and menu actions on
paired-host spawnKind update support. In
apps/ios/ADE/Views/Work/WorkSessionDestinationView.swift:1583-1585, pass each
callback only when supported; in
apps/ios/ADE/Views/Work/WorkRootComponents.swift:570-573, add the availability
input to WorkSessionListRow, and at 678-688 require it before enabling either
action. In apps/ios/ADE/Views/Work/WorkRootScreen.swift:1208-1209, derive and
pass it from the matching SyncService capability. Add regression test
testRoleTransitionActionsAreHiddenWhenSpawnKindUpdateIsUnsupported.
In `@apps/ios/ADE/Views/Work/WorkSessionDestinationView`+Actions.swift:
- Around line 419-424: Update the action handling around the existing
chat-summary update logic to build the modified summary from composerChatSummary
when chatSummary is nil, applying updated.spawnKind and
updated.subagentTakeoverPromptShownAt. Persist the result to chatSummary,
lastKnownChatSummary, and syncService.chatSummaryCache so fallback-rendered
state is updated; preserve the current path when chatSummary is present. Add
regression test
testTakeoverAndKeepReportingUpdateFallbackSummaryWhenChatSummaryIsNil.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: c9d7f85f-baca-436a-887d-d6657531ed58
⛔ Files ignored due to path filters (3)
docs/features/agents/README.mdis excluded by!docs/**docs/features/chat/README.mdis excluded by!docs/**docs/logging.mdis excluded by!docs/**
📒 Files selected for processing (29)
apps/ade-cli/README.mdapps/ade-cli/src/adeRpcServer.tsapps/ade-cli/src/cli.test.tsapps/ade-cli/src/cli.tsapps/ade-cli/src/tuiClient/__tests__/sessionLifecycle.test.tsxapps/ade-cli/src/tuiClient/adeApi.tsapps/ade-cli/src/tuiClient/app.tsxapps/ade-cli/src/tuiClient/commands.tsapps/ade-cli/src/tuiClient/sessionLifecycle.tsapps/desktop/src/main/services/adeActions/registry.tsapps/desktop/src/main/services/chat/agentChatService.test.tsapps/desktop/src/main/services/chat/agentChatService.tsapps/desktop/src/main/services/chat/spawnMissionOwnership.test.tsapps/desktop/src/main/services/chat/spawnMissionOwnership.tsapps/desktop/src/renderer/components/chat/AgentChatMessageList.tsxapps/desktop/src/renderer/components/chat/AgentChatPane.tsxapps/desktop/src/renderer/components/chat/ChatSubagentTakeoverBanner.tsxapps/desktop/src/renderer/components/terminals/SessionContextMenu.test.tsxapps/desktop/src/renderer/components/terminals/SessionContextMenu.tsxapps/desktop/src/renderer/components/terminals/sessionLifecycleActions.tsapps/desktop/src/shared/types/chat.tsapps/ios/ADE/Models/RemoteModels.swiftapps/ios/ADE/Services/SyncService.swiftapps/ios/ADE/Views/Work/WorkChatSessionView.swiftapps/ios/ADE/Views/Work/WorkRootComponents.swiftapps/ios/ADE/Views/Work/WorkRootScreen+Actions.swiftapps/ios/ADE/Views/Work/WorkRootScreen.swiftapps/ios/ADE/Views/Work/WorkSessionDestinationView+Actions.swiftapps/ios/ADE/Views/Work/WorkSessionDestinationView.swift
Comment on lines
+419
to
+424
| if var summary = chatSummary { | ||
| summary.spawnKind = updated.spawnKind | ||
| summary.subagentTakeoverPromptShownAt = updated.subagentTakeoverPromptShownAt | ||
| chatSummary = summary | ||
| syncService.cacheChatSummary(summary) | ||
| } |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Apply the returned state when chatSummary is nil.
composerChatSummary can render the banner from lastKnownChatSummary or syncService.chatSummaryCache. If chatSummary is nil, both actions discard updated. The cached state can then remain .subagent with no prompt timestamp after a successful action.
Build the update from composerChatSummary. Update chatSummary, lastKnownChatSummary, and syncService.chatSummaryCache.
Add regression test testTakeoverAndKeepReportingUpdateFallbackSummaryWhenChatSummaryIsNil.
Also applies to: 440-445
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@apps/ios/ADE/Views/Work/WorkSessionDestinationView`+Actions.swift around
lines 419 - 424, Update the action handling around the existing chat-summary
update logic to build the modified summary from composerChatSummary when
chatSummary is nil, applying updated.spawnKind and
updated.subagentTakeoverPromptShownAt. Persist the result to chatSummary,
lastKnownChatSummary, and syncService.chatSummaryCache so fallback-rendered
state is updated; preserve the current path when chatSummary is present. Add
regression test
testTakeoverAndKeepReportingUpdateFallbackSummaryWhenChatSummaryIsNil.
Human messages no longer steal the parent report channel. Takeover is an explicit demote-to-peer action with a composer banner, session menu, CLI, TUI, and iOS parity. Co-authored-by: Cursor <cursoragent@cursor.com>
…picker. Phone Take over was gated on chat.setSpawnKind, which the host never advertised, and chat.updateSession dropped spawnKind. Also restore selectReasoningEffort after the takeover insert ate its header. Co-authored-by: Cursor <cursoragent@cursor.com>
arul28
force-pushed
the
ade-138-subagent-takeover-ux-explicit-ownership-popup-demote-promote-stop-silent-peer-demotion
branch
from
August 12, 2026 19:17
4c7b98b to
aff9aa2
Compare
arul28
deleted the
ade-138-subagent-takeover-ux-explicit-ownership-popup-demote-promote-stop-silent-peer-demotion
branch
August 12, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ADE-138
Summary
Test plan
Linked Linear issues
Summary by CodeRabbit
demote,promote, andkeep-reporting, plus corresponding TUI commands.