Skip to content

ADE-136 CTO follow-ups: unverified-in-app tool wiring, attention probe false-clear, and residue from #986/#987 -> Primary - #1005

Merged
arul28 merged 3 commits into
mainfrom
ade-136-cto-follow-ups-unverified-in-app-tool-wiring-attention-probe-false-clear-and-residue-from-986-987
Aug 1, 2026
Merged

ADE-136 CTO follow-ups: unverified-in-app tool wiring, attention probe false-clear, and residue from #986/#987 -> Primary#1005
arul28 merged 3 commits into
mainfrom
ade-136-cto-follow-ups-unverified-in-app-tool-wiring-attention-probe-false-clear-and-residue-from-986-987

Conversation

@arul28

@arul28 arul28 commented Aug 1, 2026

Copy link
Copy Markdown
Owner

Fixes ADE-136

Linked Linear issues

ADE   Open in ADE  ·  ade-136-cto-follow-ups-unverified-in-app-tool-wiring-attention-probe-false-clear-and-residue-from-986-987 branch  ·  PR #1005

Summary by CodeRabbit

  • New Features

    • CTO attention now clearly reports Idle, Awaiting input, or Unknown states across desktop, web, and iOS.
    • Added consistent CTO attention access through web clients and browser previews.
    • Updated CTO capability guidance to reference the latest available operator tools.
  • Bug Fixes

    • Preserved the last known attention indicator when status checks fail or return an unknown result.
    • Improved compatibility with interrupt and rewind responses from supported AI services.
  • Tests

    • Expanded coverage for attention states, transport behavior, legacy responses, and failure handling.

@linear-code

linear-code Bot commented Aug 1, 2026

Copy link
Copy Markdown

ADE-136

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ade Ignored Ignored Preview Aug 1, 2026 10:23pm

@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@arul28, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3790bf07-fa46-4e1d-bea7-96317308af3d

📥 Commits

Reviewing files that changed from the base of the PR and between d41a9d9 and bf339a2.

📒 Files selected for processing (4)
  • apps/desktop/src/main/services/cto/ctoPromptContent.ts
  • apps/desktop/src/main/services/cto/ctoState.test.ts
  • apps/ios/ADE/Services/SyncService.swift
  • apps/ios/ADETests/ADETests.swift
📝 Walkthrough

Walkthrough

The PR adds explicit CTO attention statuses across desktop, headless, web, and iOS clients. It preserves known attention state after unknown probes, adds adapter coverage, normalizes Claude SDK responses, updates CTO capability text, and aligns PTY and steering contracts.

Changes

CTO attention state and propagation

Layer / File(s) Summary
Attention contract and host results
apps/desktop/src/shared/types/cto.ts, apps/desktop/src/main/services/chat/agentChatService.ts, apps/ade-cli/src/headlessLinearServices.ts, apps/desktop/src/main/services/ipc/registerIpc.ts, apps/desktop/src/main/services/adeActions/registry.ts, apps/desktop/src/main/services/sync/syncRemoteCommandService.test.ts, apps/ade-cli/src/headlessLinearServices.test.ts, apps/desktop/src/main/services/chat/agentChatService.test.ts
CTO attention now reports idle, awaiting-input, or unknown. Host results, fallbacks, and tests use the explicit status field.
Desktop and iOS state propagation
apps/desktop/src/renderer/webclient/adapter/misc.ts, apps/desktop/src/renderer/webclient/adapter/__tests__/adapter.test.ts, apps/desktop/src/renderer/browserMock.ts, apps/desktop/src/renderer/hooks/useCtoAttention.ts, apps/desktop/src/renderer/hooks/useCtoAttention.test.tsx, apps/desktop/src/renderer/state/appStore.ts, apps/ios/ADE/Models/RemoteModels.swift, apps/ios/ADE/Services/SyncService.swift, apps/ios/ADE/App/ContentView.swift, apps/ios/ADETests/ADETests.swift
Desktop and iOS clients preserve known attention state when a probe is unknown. UI badges and accessibility text use derived awaiting-input state.
Claude SDK response normalization
apps/desktop/src/main/services/chat/claudeSdkCompat.ts, apps/desktop/src/main/services/chat/agentChatService.ts
Interrupt receipts and rewind skipped-link values are normalized before agent chat processing.
CTO tooling and integration contracts
apps/desktop/src/main/services/ai/tools/ctoOperatorTools.ts, apps/desktop/src/main/services/chat/agentChatService.ts, apps/desktop/src/main/services/sync/syncHostService.test.ts
PTY creation uses the shared PtyCreateArgs contract. CTO dependency wiring removes a cast, and sync tests use steerUserMessage.
CTO capability manifest
apps/desktop/src/main/services/cto/ctoPromptContent.ts, apps/desktop/src/main/services/cto/ctoState.test.ts
The capability manifest references registered operator tool schemas instead of duplicating individual tool descriptions.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related issues

Possibly related PRs

  • arul28/ADE#987 — Introduced the CTO attention state and iOS sync/UI paths refined here.
  • arul28/ADE#789 — Modifies related Claude interrupt and steering handling in agentChatService.ts.
  • arul28/ADE#791 — Modifies related Claude steering and lifecycle handling.

Suggested labels: desktop, ios, docs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 30.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the CTO attention-state fixes, tool-wiring updates, and cleanup included in the changeset.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ade-136-cto-follow-ups-unverified-in-app-tool-wiring-attention-probe-false-clear-and-residue-from-986-987

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@apps/desktop/src/main/services/cto/ctoPromptContent.ts`:
- Line 23: Change the capability heading in
apps/desktop/src/main/services/cto/ctoPromptContent.ts at lines 23-23 to
sentence case, using “# ADE operator tools”; update the corresponding expected
heading in apps/desktop/src/main/services/cto/ctoState.test.ts at lines 279-279
to match.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 2c2437fa-47a6-4fa6-bace-16488973b3a6

📥 Commits

Reviewing files that changed from the base of the PR and between 74a9d44 and d41a9d9.

⛔ Files ignored due to path filters (5)
  • docs/ARCHITECTURE.md is excluded by !docs/**
  • docs/features/chat/README.md is excluded by !docs/**
  • docs/features/cto/README.md is excluded by !docs/**
  • docs/features/sync-and-multi-device/ios-companion.md is excluded by !docs/**
  • docs/features/sync-and-multi-device/remote-commands.md is excluded by !docs/**
📒 Files selected for processing (23)
  • apps/ade-cli/src/headlessLinearServices.test.ts
  • apps/ade-cli/src/headlessLinearServices.ts
  • apps/desktop/src/main/services/adeActions/registry.ts
  • apps/desktop/src/main/services/ai/tools/ctoOperatorTools.ts
  • apps/desktop/src/main/services/chat/agentChatService.test.ts
  • apps/desktop/src/main/services/chat/agentChatService.ts
  • apps/desktop/src/main/services/chat/claudeSdkCompat.ts
  • apps/desktop/src/main/services/cto/ctoPromptContent.ts
  • apps/desktop/src/main/services/cto/ctoState.test.ts
  • apps/desktop/src/main/services/ipc/registerIpc.ts
  • apps/desktop/src/main/services/sync/syncHostService.test.ts
  • apps/desktop/src/main/services/sync/syncRemoteCommandService.test.ts
  • apps/desktop/src/renderer/browserMock.ts
  • apps/desktop/src/renderer/hooks/useCtoAttention.test.tsx
  • apps/desktop/src/renderer/hooks/useCtoAttention.ts
  • apps/desktop/src/renderer/state/appStore.ts
  • apps/desktop/src/renderer/webclient/adapter/__tests__/adapter.test.ts
  • apps/desktop/src/renderer/webclient/adapter/misc.ts
  • apps/desktop/src/shared/types/cto.ts
  • apps/ios/ADE/App/ContentView.swift
  • apps/ios/ADE/Models/RemoteModels.swift
  • apps/ios/ADE/Services/SyncService.swift
  • apps/ios/ADETests/ADETests.swift

Comment thread apps/desktop/src/main/services/cto/ctoPromptContent.ts Outdated
@arul28

arul28 commented Aug 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 2d4ae9dfd3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/ios/ADE/Services/SyncService.swift
@arul28

arul28 commented Aug 1, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: bf339a2bc0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@arul28
arul28 merged commit 95561c0 into main Aug 1, 2026
4 checks passed
@arul28
arul28 deleted the ade-136-cto-follow-ups-unverified-in-app-tool-wiring-attention-probe-false-clear-and-residue-from-986-987 branch August 1, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant