Repository navigation
Give locked HTTP batch items distinct audit receipts - #344
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Locked HTTP batch evaluation selected one request timestamp and reused the runtime's deterministic default stream ID. Two identical intents in a batch therefore produced the same audit stream ID and receipt hash, making separate evaluations indistinguishable in the evidence.
Change
stream_idsalongsidestream_id.stream_idsto the direct batch API for trusted hosts, while retaining deterministic local defaults for fixed inputs and time.Verification
The new HTTP regression failed on the previous implementation (32-character deterministic ID) and now checks distinct IDs, distinct receipt hashes, and valid receipts. The focused tests (43/43), full Node test suite, public contract and deployment surface checks, local link check, consumer compatibility, API stability, and upgrade contract checks pass.
Audit IDs distinguish evaluations; they do not establish caller identity or truthfulness of declared intent.