Repository navigation
Prevent deployment cache from crossing shadow and enforce policies - #342
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The deployment cache previously keyed a result by intent, profile, context, and timestamp, but omitted rollout mode and failure mode. A suppressed intent evaluated in
shadowcould be returned by a laterenforcecall aseffective_allowed: true. An explicitcache_keyalso replaced the input identity entirely, allowing different intents to share a result.This change binds cache entries to the canonical snapshot actually evaluated: intent, profile, context, fixed timestamp, audit stream ID, mode, failure mode, and optional operator namespace. Manual keys cannot substitute for a fixed timestamp. Cache lookup/storage failures leave the computed decision intact.
Reproduction and verification
mode: "shadow",effective_allowed: true,cache.hit: true.mode: "enforce",effective_allowed: false; separate cache entries preserve repeat hits within each mode.node --test test/deployment-firewall.test.js test/rollout-runtime.test.js— 21 passed.node --test --test-reporter=dot— passed.node scripts/check-deployment-surfaces.mjs,node examples/deployment-rollout.mjs,node scripts/check-api-stability.mjs,git diff --check— passed.The tests and behavior here are project-authored engineering evidence. This does not claim independent validation or production suitability.