Skip to content

Fix Standalone Adapter Conflict Resolution and Vite+ Detection - #334

Merged
torn4dom4n merged 5 commits into
refactor-autofix-architecture-15113170007543883834from
jules-15429086788352666181-0aeef3c1
Nov 10, 2026
Merged

torn4dom4n merged 5 commits into
refactor-autofix-architecture-15113170007543883834from
jules-15429086788352666181-0aeef3c1

Conversation

@google-labs-jules

Copy link
Copy Markdown
Contributor

Resolves PR #327 review findings:

  1. F-01 (Medium): Standalone adapters now participate in the same capability conflict-resolution mechanism as regular adapters, preventing duplicate tasks and respecting adapter precedence and capability coverage.
  2. F-02 (Low): Vite+ tool detection uses structured command invocation parsing instead of substring matching, preventing false positives from echo statements, comments, or unrelated arguments.

PR created automatically by Jules for task 15429086788352666181 started by @torn4dom4n

…tection

- F-01: Include standalone adapters in capability conflict resolution by reusing processCandidateTools and sharing coveredCapabilities.
- F-02: Make Vite+ detection resistant to false positives using parseCommandInvocations.
- Rebuild dist/autofix.mjs bundle.
- Add changeset and comprehensive regression tests.
@google-labs-jules

Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@changeset-bot

changeset-bot Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7a802a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@area44/workflows Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

…ection

- F-01: Preserve capability isolation across language providers using scope-based capability tracking (adapter.scope ?? provider.id / 'standalone'), preventing unrelated language providers from suppressing each other's execution tasks.
- F-02: Support Vite+ detection through command wrappers (cross-env, sh -c, bash -c, package-manager runners, script delegations) via unwrapEnvironmentWrapper and hasVitePlusCommand.
- Rebuild dist/autofix.mjs bundle.
- Add changeset and comprehensive regression tests.
… parsing

- F-01: Clarify and correct standalone adapter scope semantics with explicit conflict domains, defaulting unassigned standalone adapters to isolated per-adapter scopes (standalone:${id}) and unassigned provider adapters to provider.id.
- F-02: Implement option-aware parsing in unwrapEnvironmentWrapper for cross-env and cross-env-shell to handle options consuming separate arguments (-f, --file, -c, --config, --env-file), inline values (--option=val), boolean flags, and delimiter -- while failing closed on unrecognized options.
- Rebuild dist/autofix.mjs bundle.
- Add changeset and comprehensive regression tests.
- Align unwrapEnvironmentWrapper with actual cross-env CLI syntax by removing hypothetical options (-f, --file, etc.) and stripping leading environment variable assignments.
- Update regression tests to verify valid cross-env invocations and prevent false-positive detection from unsupported options or unrelated commands.
- Synchronize dist/autofix.mjs bundle.
- Expose syntax error diagnostics via parseCommandInvocationsDetailed.
- Make hasVitePlusCommand reject commands containing confirmed shell syntax errors (unterminated quotes, trailing escapes).
- Synchronize dist/autofix.mjs bundle.
- Add regression tests covering malformed commands and wrappers.
@torn4dom4n
torn4dom4n merged commit 947dcad into refactor-autofix-architecture-15113170007543883834 Nov 10, 2026
18 checks passed
@torn4dom4n
torn4dom4n deleted the jules-15429086788352666181-0aeef3c1 branch November 10, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant