Repository navigation
fix(autofix): shell parser safety and check script fallback - #331
Conversation
- Prevent unsafe shell commands with redirections, backgrounding, or substitutions from being classified as read-only - Fail closed on malformed quotes and incomplete command substitutions - Fall back to fmt:check when format:check cannot be safely classified as read-only - Regenerate dist/autofix.mjs bundle - Add regression test coverage for shell safety and check script candidate fallback
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
d14e2dd
into
refactor-autofix-architecture-15113170007543883834
Addresses PR #327 review feedback:
&), output redirections (>,>>,2>,2>>,&>), process substitutions (<(),>()), command substitutions ($(), backticks), and malformed quotes/escapes. Commands containing these constructs fail closed and cannot be classified as "read-only", preventing them from being scheduled in check mode while allowing valid quoted arguments and escaped characters to work.format:checkfirst, selecting it only if verified as "read-only", and falling back tofmt:checkifformat:checkis absent, write-capable, or unknown.PR created automatically by Jules for task 69303809989503385 started by @torn4dom4n