Repository navigation
Return false from log/logf when the packet could not be sent - #33
Merged
Merged
Conversation
_sendLog ignored the result of UDP::endPacket() and always returned true, so a packet dropped by the network stack (e.g. full ARP queue on ESP32) was reported as sent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015dqPaWXEZmNHreFax2RpKq
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_sendLogignored the result ofUDP::endPacket()and always returnedtrue. When the network stack drops a packet,log()/logf()still reported success. For example, on ESP32sendtofails withENOMEMwhen the ARP queue (3 packets) is full right after connecting.Now
log()/logf()returnfalsewhenendPacket()fails, so sketches can detect lost messages. This helps diagnose #22.Behaviour is otherwise unchanged. Messages filtered out by
logMaskstill returntrue.Test plan
falsefor dropped packets (diagnostic sketch in Examples fail to deliver first messages #22)🤖 Generated with Claude Code
https://claude.ai/code/session_015dqPaWXEZmNHreFax2RpKq