Repository navigation
Conversation
These profiles listed `ExtensionType::Grease` twice in `extension_order`. rustls has a single GREASE extension type (0xbaba), so the ClientHello carried it twice. TLS 1.3 forbids repeated extensions, and BoringSSL-based servers (Google, Cloudflare, Let's Encrypt) rejected the handshake with `decode_error`. JA3 and JA4 are unchanged, since both ignore GREASE. Adds a test that builds every profile's ClientHello and checks that no extension type appears twice. Fixes apify#575 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #575.
chrome_100(shared by chrome101–116) andios_18listedExtensionType::Greasetwice inextension_order. The rustls fork has one GREASE extension type (0xbaba), so it went out twice and BoringSSL servers rejected the handshake. This drops the second one and adds a test that builds every profile's ClientHello and checks that no extension type repeats.With the fix, these profiles connect to Google, Cloudflare and Let's Encrypt again. JA3 and JA4 are unchanged; only peetprint changes, since the ClientHello now has one GREASE extension instead of two.