Repository navigation
feat(node): support timeout: null to disable the request timeout - #572
Merged
Merged
Conversation
barjin
marked this pull request as ready for review
October 14, 2026 12:12
apify-service-account
added
tested
Pijukatel
approved these changes
Oct 14, 2026
Pijukatel
left a comment
Pijukatel
left a comment
Contributor
There was a problem hiding this comment.
Just a readability nit.
Comment on lines
+139
to
+140
| Either::A(millis) => Some(Duration::from_millis(millis.into())), | ||
| Either::B(_) => None, |
Contributor
There was a problem hiding this comment.
I do not know what is idiomatic in Rust, but to me it seems less readable.
When using Either::A(...), Either::B(...) I do not have enough context to read that line. I need to find the type in a different file and see what was the first option and what was the second option. I would prefer a named variant where I would get all the context from the variant name already.
Member
Author
There was a problem hiding this comment.
Agreed, but this Either<...,...> is from the napi-rs lib (has effect on the generated TS types etc). Making a custom type compatible with this would take more effort than this is worth imo :/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fetchnow acceptstimeout: nullto disable the request timeout, matchingtimeout=Nonein the Python bindings.Closes #571