Repository navigation
refactor!: remove build-for-test and release composite commands - #203
Open
metalwarrior665 wants to merge 2 commits into
Open
metalwarrior665 wants to merge 2 commits into
metalwarrior665 wants to merge 2 commits into
Conversation
The workflows already use the atomic commands, so the composites were only shortcuts. Without them: - get-affected-actors returns its JSON document directly, there is no internal shape to convert from anymore - notifyToSlack takes the repo URL and derives the author itself, the release-only wrapper is gone - TEST_VERSION_NUMBER is gone, the CLI knows nothing about 0.99 The README documents the PR and release flows as pipelines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012dp3mSDDgp5u2QVBT54EpX
metalwarrior665
added this pull request to stack #194
October 15, 2026 17:15
metalwarrior665
marked this pull request as ready for review
October 15, 2026 17:18
metalwarrior665
requested review from
JuanGalilea and
ruocco-l
as code owners
October 15, 2026 17:18
JuanGalilea
approved these changes
Oct 16, 2026
…commands Brings in master's bundled CLI (#200). The bundle and e2e tests of `build-for-test` and `release` move to the commands that replace them: `get-affected-actors --since`, `build --version-number default` and `notify-release`. The bundle is rebuilt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012dp3mSDDgp5u2QVBT54EpX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we use atomic commands in workflows, there is probably not much reason to offer the composites as long as we can document the chains well.
Stacked on #193. This is an experiment to see how much the code shrinks without the composite commands. The workflows already use the atomic commands, so they don't change.
Removed
build-for-test, replaced byget-affected-actors --base … | jq '{ actors: .functionallyChangedActors }' | build --version-number 0.99release, replaced byget-affected-actors --since <sha>, thenbuild --version-number defaulton both lists, thennotify-releaseSimplified as a result
getAffectedActorsreturns the versioned JSON document directly.toAffectedActorsDocumentis gone, because no internal caller needs the full Actor configs anymore.announceReleaseis merged intonotifyToSlack:repoUrland gets the author from the newest commit;repositoryandauthorare no longer parameters.TEST_VERSION_NUMBERis gone, so the CLI knows nothing about the 0.99 convention.main.tsno longer needsbuildForTestOptionsor the composite handlers.Size
bin/: 36 insertions, 153 deletions. Including tests and README: 110 insertions, 280 deletions.Docs
The README now describes the local PR flow, the "Full example" and the release as pipelines. The
--base-commitsection became "The last released commit (--since)", with the same merge-strategy table and the same failure cases.Checks
tsc, eslint, prettier and vitest (398 passed) all pass locally. Knip reports only the existing false positives caused by
bin/main.tsnot being a knip entry, one fewer than before.🤖 Generated with Claude Code
https://claude.ai/code/session_012dp3mSDDgp5u2QVBT54EpX
Generated by Claude Code