Repository navigation
Conversation
When a creation date is set with FOUserAgent.setCreationDate(), use it for xmp:MetadataDate too, so it matches xmp:CreateDate and /CreationDate. Without a creation date the current time is used, as before.
Author
|
Superseded by #134, which keeps the current time in the file ID by default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/FOP-3367
Smaller alternative to #132, with only the part that was not questioned in the JIRA issue: when a creation date is set with
FOUserAgent.setCreationDate(), use it forxmp:MetadataDatetoo, so it matchesxmp:CreateDateand/CreationDate. The file ID is not touched.IFRendererandPDFRenderingUtil: MetadataDate is the creation date when one is set, the current time otherwise.PDFCreationDateTestCase: fails on main (1301bcf) and passes with this change.On its own this does not give the same PDF twice, because the file ID still uses the current time. #132 adds an opt in option for the file ID that does. Please merge whichever you prefer.
The full fop-core suite passes (3730 tests) and checkstyle reports no violations.