[Performance] Optimize DataSetWithoutTimeGenerator merge hot path - #912
Open
Caideyipi wants to merge 1 commit into
Open
[Performance] Optimize DataSetWithoutTimeGenerator merge hot path#912Caideyipi wants to merge 1 commit into
Caideyipi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed:
DataSetWithoutTimeGenerator already scans every series for each emitted RowRecord. This change computes the next minimum timestamp during that required scan, replacing the additional boxed List/Boolean state, LongHeapPriorityQueue, and LongOpenHashSet maintenance.
The merge behavior is covered across sparse timestamps, batch boundaries, empty readers, duplicate timestamps, and Long.MIN_VALUE/Long.MAX_VALUE.
Validation:
The branch is based on the latest upstream/develop and has only been pushed to the contributor fork.