Skip to content

Revert "[perf] use precompiled pattern" - #1075

Merged
volosied merged 1 commit into
apache:4.1.xfrom
volosied:4.1.x
Sep 2, 2026
Merged

Revert "[perf] use precompiled pattern"#1075
volosied merged 1 commit into
apache:4.1.xfrom
volosied:4.1.x

Conversation

@volosied

@volosied volosied commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

This reverts commit 5e56abd.

Binary compatibility tool reported that jakarta.faces.validator.BeanValidator changed:
image

I cannot recall if this is allowed (new field), but I think the specs needs to match 1:1.

@tandraschko

Copy link
Copy Markdown
Member

Why not just make it private and duplicate it in the other class?

@tandraschko

Copy link
Copy Markdown
Member

But propably not worth, im ok with revert
Please also port it master

@volosied

volosied commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

I thought about that, but then I would have to declare the variable in three different classes and make it private.

So I opted to revert it for simplicity.

@volosied
volosied merged commit 67a2694 into apache:4.1.x Sep 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants